Closed jronak closed 3 years ago
Merging #330 (994fddf) into dev (b68c9de) will decrease coverage by
0.18%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## dev #330 +/- ##
==========================================
- Coverage 90.49% 90.30% -0.19%
==========================================
Files 54 54
Lines 2671 2671
==========================================
- Hits 2417 2412 -5
- Misses 179 182 +3
- Partials 75 77 +2
Impacted Files | Coverage Δ | |
---|---|---|
handler.go | 80.89% <0.00%> (-2.81%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b68c9de...994fddf. Read the comment docs.
I am seeing some documentation updates along the release(https://github.com/yarpc/yab/pull/330/commits/cbc36c744329f37f74b972782097597dfaf09c9f), can we do this in another PR? It is extremely painful to review this here since we do not know what was really added or not.
Update README and changelog with gRPC streaming and other details.
Changelog
-request
, optionally delimited by space or comma-request='{"request": "1"} {"request": "2"}'
-request='-'
, this is useful with bi-directional streaming to interactively send and receive stream messages-stream-interval='5s'
, this ensures there is at least a gap of 5 seconds between requestsgrpc-max-response-size
option to accept large responses for gRPC calls.