search

yarpc / yab

Call and benchmark YARPC services from the command line.
MIT License
86 stars 35 forks source link

Fix protobuf reflection hung calls #337

Closed jronak closed 3 years ago

jronak commented 3 years ago

I have added a test to confirm the issue of the hung call in protobuf reflection methods. This change fixes it by adding a context deadline around the Protobuf reflection gRPC stream call.

Fixes: #335

codecov[bot] commented 3 years ago

Codecov Report

Merging #337 (abee892) into dev (28df925) will decrease coverage by 0.05%. The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #337      +/-   ##
==========================================
- Coverage   90.26%   90.21%   -0.06%     
==========================================
  Files          54       54              
  Lines        2702     2708       +6     
==========================================
+ Hits         2439     2443       +4     
- Misses        184      185       +1     
- Partials       79       80       +1
Impacted Files Coverage Δ
protobuf/source_reflection.go 96.22% <84.61%> (-3.78%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 28df925...abee892. Read the comment docs.