yarpc / yarpc-go

A message passing platform for Go
MIT License
404 stars 102 forks source link

Transient failure of gRPC TLS test #1854

Closed kriskowal closed 4 years ago

kriskowal commented 4 years ago

Within vim, testing the gRPC transport’s TLS support reliably fails with connection errors instead of TLS errors, but consistently passes in Docker. There may be a behavior difference between Linux and OS X.

I intend to disable (Skip) TestTLSWithYARPCAndGRPC until we find a resolution.

transport/grpc/logger.go|130| 2019-11-27T15:41:01.320-0800  INFO    started GRPC inbound    {"address": "127.0.0.1:63473"}
transport/grpc/integration_test.go|164| 
||  Error Trace:    integration_test.go:164
||                              integration_test.go:150
||                              integration_test.go:406
||                              integration_test.go:148
||  Error:          "code:unavailable message:all SubConns are in TransientFailure, latest connection error: connection closed" does not contain "remote error: tls: bad certificate"
||  Test:           TestTLSWithYARPCAndGRPC/invalid_client_cert
transport/grpc/integration_test.go|164| 
||  Error Trace:    integration_test.go:164
||                              integration_test.go:153
||                              integration_test.go:406
||                              integration_test.go:148
||  Error:          "rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection closed" does not contain "remote error: tls: bad certificate"
||  Test:           TestTLSWithYARPCAndGRPC/invalid_client_cert
abhinav commented 4 years ago

This is now an issue in CI and Docker as well.

https://buildkite.com/uberopensource/yarpc-go/builds/2754#e5a1b696-80f6-4014-b87c-3257933abcdc