yarpc / yarpc-go

A message passing platform for Go
MIT License
405 stars 103 forks source link

Fix layout of Outbounds table on debug page #2130

Open jkanywhere opened 2 years ago

jkanywhere commented 2 years ago

The two header rows on the HTML table for Outbounds on the debug page now have the same number of cells.

This will make the columns line up properly.

jkanywhere commented 2 years ago

Before:

image

After:

image
jronak commented 2 years ago

@jkanywhere license/cla check seems to be stuck (you could push the same amended commit to trigger this check again)

codecov[bot] commented 2 years ago

Codecov Report

Merging #2130 (cfbe060) into dev (707eebc) will decrease coverage by 0.05%. The diff coverage is n/a.

:exclamation: Current head cfbe060 differs from pull request most recent head 02264c0. Consider uploading reports for the commit 02264c0 to get more accurate results

@@            Coverage Diff             @@
##              dev    #2130      +/-   ##
==========================================
- Coverage   87.75%   87.70%   -0.06%     
==========================================
  Files         253      251       -2     
  Lines       14090    14041      -49     
==========================================
- Hits        12365    12314      -51     
- Misses       1336     1338       +2     
  Partials      389      389              
Impacted Files Coverage Δ
x/debug/debug.go 86.95% <ø> (ø)
transport/tchannel/peer.go 94.73% <0.00%> (-2.64%) :arrow_down:
dispatcher_startup.go 91.07% <0.00%> (-1.79%) :arrow_down:
peer/hashring32/internal/hashring32/hashring32.go 96.21% <0.00%> (-1.09%) :arrow_down:
internal/observability/graph.go 93.12% <0.00%> (-0.63%) :arrow_down:
transport/internal/tlsmux/listener.go
transport/internal/tlsmux/conn_sniffer.go

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 707eebc...02264c0. Read the comment docs.