search

yarpc / yarpc-go

A message passing platform for Go
MIT License
401 stars 101 forks source link

[5/n] tlsmux: process tls handshake #2137

Closed jronak closed 2 years ago

jronak commented 2 years ago

Ideally, TLS connections do not require manually handshake invocation as it happens on the first read/write call on the connection. The first r/w call would happen inside the transport server, and due to this, we cannot capture TLS handshake error (version mismatch, invalid certs). Muxer preemptively triggers TLS handshake to catch essential errors and emit metrics around it in the following diffs.

codecov[bot] commented 2 years ago

Codecov Report

Merging #2137 (465b69e) into dev (59071ee) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #2137      +/-   ##
==========================================
+ Coverage   87.66%   87.70%   +0.04%     
==========================================
  Files         253      253              
  Lines       14085    14090       +5     
==========================================
+ Hits        12347    12358      +11     
+ Misses       1344     1339       -5     
+ Partials      394      393       -1
Impacted Files Coverage Δ
transport/internal/tlsmux/listener.go 87.87% <100.00%> (+20.02%) :arrow_up:
transport/tchannel/peer.go 96.05% <0.00%> (+1.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59071ee...465b69e. Read the comment docs.