search

yarpc / yarpc-go

A message passing platform for Go
MIT License
405 stars 103 forks source link

[6/n] tlsmux: add metrics observer #2138

Closed jronak closed 2 years ago

jronak commented 2 years ago

Emit metrics on creating TLS/plaintext connections and count of TLS handshake errors. For reviews: start review from observer.go file

codecov[bot] commented 2 years ago

Codecov Report

Merging #2138 (65b9f88) into dev (707eebc) will decrease coverage by 0.04%. The diff coverage is 88.70%.

@@            Coverage Diff             @@
##              dev    #2138      +/-   ##
==========================================
- Coverage   87.75%   87.70%   -0.05%     
==========================================
  Files         253      254       +1     
  Lines       14090    14148      +58     
==========================================
+ Hits        12365    12409      +44     
- Misses       1336     1343       +7     
- Partials      389      396       +7
Impacted Files Coverage Δ
transport/internal/tlsmux/observer.go 87.75% <87.75%> (ø)
transport/internal/tlsmux/listener.go 88.09% <92.30%> (+0.21%) :arrow_up:
dispatcher_startup.go 91.07% <0.00%> (-1.79%) :arrow_down:
transport/tchannel/peer.go 96.05% <0.00%> (-1.32%) :arrow_down:
peer/hashring32/internal/hashring32/hashring32.go 96.21% <0.00%> (-1.09%) :arrow_down:
internal/observability/graph.go 93.12% <0.00%> (-0.63%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 707eebc...65b9f88. Read the comment docs.