search

yarpc / yarpc-go

A message passing platform for Go
MIT License
405 stars 103 forks source link

[8/n] tlsmux: set timeout on connection read and tls handshake #2140

Closed jronak closed 2 years ago

jronak commented 2 years ago

This PR adds a connection read timeout during sniffing and reset after completion. It also sets a timeout on the TLS handshake.

codecov[bot] commented 2 years ago

Codecov Report

Merging #2140 (2c64721) into dev (1d5e449) will decrease coverage by 0.00%. The diff coverage is 75.00%.

@@            Coverage Diff             @@
##              dev    #2140      +/-   ##
==========================================
- Coverage   87.71%   87.71%   -0.01%     
==========================================
  Files         254      254              
  Lines       14182    14189       +7     
==========================================
+ Hits        12440    12446       +6     
  Misses       1347     1347              
- Partials      395      396       +1
Impacted Files Coverage Δ
transport/internal/tlsmux/listener.go 86.74% <75.00%> (-1.42%) :arrow_down:
transport/tchannel/peer.go 96.05% <0.00%> (-1.32%) :arrow_down:
internal/observability/graph.go 93.75% <0.00%> (+0.62%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d5e449...2c64721. Read the comment docs.