yarpc / yarpc-go

A message passing platform for Go
MIT License
401 stars 101 forks source link

tls: refactor mux listener into tls package #2161

Closed jronak closed 1 year ago

jronak commented 1 year ago

Refactor the internal tlsmux package into tls/muxlistener. Going forwardtls internal package will hold all the sub-packages related to inbound and outbound tls.

codecov[bot] commented 1 year ago

Codecov Report

Base: 81.06% // Head: 87.72% // Increases project coverage by +6.66% :tada:

Coverage data is based on head (ec4a313) compared to base (d332645). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2161 +/- ## ========================================== + Coverage 81.06% 87.72% +6.66% ========================================== Files 254 254 Lines 14315 14315 ========================================== + Hits 11604 12558 +954 + Misses 2206 1359 -847 + Partials 505 398 -107 ``` | [Impacted Files](https://codecov.io/gh/yarpc/yarpc-go/pull/2161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc) | Coverage Δ | | |---|---|---| | [transport/internal/tls/muxlistener/conn\_sniffer.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L2ludGVybmFsL3Rscy9tdXhsaXN0ZW5lci9jb25uX3NuaWZmZXIuZ28=) | `100.00% <ø> (ø)` | | | [transport/internal/tls/muxlistener/listener.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L2ludGVybmFsL3Rscy9tdXhsaXN0ZW5lci9saXN0ZW5lci5nbw==) | `95.55% <ø> (ø)` | | | [transport/internal/tls/muxlistener/observer.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L2ludGVybmFsL3Rscy9tdXhsaXN0ZW5lci9vYnNlcnZlci5nbw==) | `88.00% <ø> (ø)` | | | [transport/internal/tls/muxlistener/tls\_checker.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L2ludGVybmFsL3Rscy9tdXhsaXN0ZW5lci90bHNfY2hlY2tlci5nbw==) | `100.00% <ø> (ø)` | | | [transport/grpc/inbound.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L2dycGMvaW5ib3VuZC5nbw==) | `97.43% <100.00%> (+42.30%)` | :arrow_up: | | [transport/http/inbound.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L2h0dHAvaW5ib3VuZC5nbw==) | `84.74% <100.00%> (ø)` | | | [transport/tchannel/transport.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L3RjaGFubmVsL3RyYW5zcG9ydC5nbw==) | `87.05% <100.00%> (ø)` | | | [peer/hashring32/internal/hashring32/hashring32.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-cGVlci9oYXNocmluZzMyL2ludGVybmFsL2hhc2hyaW5nMzIvaGFzaHJpbmczMi5nbw==) | `96.21% <0.00%> (-1.09%)` | :arrow_down: | | [peer/direct/direct.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-cGVlci9kaXJlY3QvZGlyZWN0Lmdv) | `100.00% <0.00%> (+2.70%)` | :arrow_up: | | [pkg/lifecycle/once.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-cGtnL2xpZmVjeWNsZS9vbmNlLmdv) | `95.06% <0.00%> (+3.70%)` | :arrow_up: | | ... and [42 more](https://codecov.io/gh/yarpc/yarpc-go/pull/2161/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.