search

yarpc / yarpc-go

A message passing platform for Go
MIT License
405 stars 103 forks source link

[4/n] tls: move observer into separate pkg #2168

Closed jronak closed 2 years ago

jronak commented 2 years ago

Move listener metrics observer into a separate package, which can be used in both muxlistener and dialer. This also adds two additional tags direction and dest in all the metrics.

codecov[bot] commented 2 years ago

Codecov Report

Base: 85.14% // Head: 85.11% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (9bc3cb9) compared to base (07f9f7f). Patch coverage: 89.65% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2168 +/- ## ========================================== - Coverage 85.14% 85.11% -0.03% ========================================== Files 269 269 Lines 15269 15279 +10 ========================================== + Hits 13001 13005 +4 - Misses 1844 1850 +6 Partials 424 424 ``` | [Impacted Files](https://codecov.io/gh/yarpc/yarpc-go/pull/2168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc) | Coverage Δ | | |---|---|---| | [transport/internal/tls/metrics/observer.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L2ludGVybmFsL3Rscy9tZXRyaWNzL29ic2VydmVyLmdv) | `76.92% <82.35%> (ø)` | | | [transport/internal/tls/muxlistener/listener.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L2ludGVybmFsL3Rscy9tdXhsaXN0ZW5lci9saXN0ZW5lci5nbw==) | `93.87% <100.00%> (+0.54%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.