search

yarpc / yarpc-go

A message passing platform for Go
MIT License
401 stars 101 forks source link

[5/n] tls: integrate metrics observer in dialer #2169

Closed jronak closed 1 year ago

jronak commented 1 year ago

Integrate metrics observer with dialer to emit metrics on successful TLS connection creation and TLS handshake failures. For reviewers, read method NewTLSDialer in dialer.go to understand integration. Merges into previous stack tls-5

codecov[bot] commented 1 year ago

Codecov Report

Base: 85.13% // Head: 85.15% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (8c1b6e9) compared to base (473d020). Patch coverage: 94.73% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2169 +/- ## ========================================== + Coverage 85.13% 85.15% +0.02% ========================================== Files 269 269 Lines 15279 15294 +15 ========================================== + Hits 13008 13024 +16 Misses 1849 1849 + Partials 422 421 -1 ``` | [Impacted Files](https://codecov.io/gh/yarpc/yarpc-go/pull/2169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc) | Coverage Δ | | |---|---|---| | [transport/internal/tls/dialer/dialer.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L2ludGVybmFsL3Rscy9kaWFsZXIvZGlhbGVyLmdv) | `91.17% <94.73%> (+12.22%)` | :arrow_up: | | [internal/observability/graph.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-aW50ZXJuYWwvb2JzZXJ2YWJpbGl0eS9ncmFwaC5nbw==) | `93.12% <0.00%> (-0.63%)` | :arrow_down: | | [peer/hashring32/internal/hashring32/hashring32.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-cGVlci9oYXNocmluZzMyL2ludGVybmFsL2hhc2hyaW5nMzIvaGFzaHJpbmczMi5nbw==) | `97.29% <0.00%> (+1.08%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.