yarpc / yarpc-go

A message passing platform for Go
MIT License
401 stars 101 forks source link

http: set destination service name in the outbound #2174

Closed jronak closed 1 year ago

jronak commented 1 year ago

Set the destination service name in the HTTP outbound. This will be used in the follow-up PR for emitting TLS connection metrics tag value.

codecov[bot] commented 1 year ago

Codecov Report

Base: 85.26% // Head: 85.27% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (94e933a) compared to base (de8976f). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2174 +/- ## ========================================== + Coverage 85.26% 85.27% +0.01% ========================================== Files 269 269 Lines 15348 15352 +4 ========================================== + Hits 13086 13091 +5 Misses 1843 1843 + Partials 419 418 -1 ``` | [Impacted Files](https://codecov.io/gh/yarpc/yarpc-go/pull/2174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc) | Coverage Δ | | |---|---|---| | [transport/http/config.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L2h0dHAvY29uZmlnLmdv) | `94.80% <100.00%> (+0.06%)` | :arrow_up: | | [transport/http/outbound.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L2h0dHAvb3V0Ym91bmQuZ28=) | `92.06% <100.00%> (+0.08%)` | :arrow_up: | | [dispatcher\_startup.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-ZGlzcGF0Y2hlcl9zdGFydHVwLmdv) | `91.07% <0.00%> (-1.79%)` | :arrow_down: | | [internal/observability/graph.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-aW50ZXJuYWwvb2JzZXJ2YWJpbGl0eS9ncmFwaC5nbw==) | `93.75% <0.00%> (+0.62%)` | :arrow_up: | | [transport/tchannel/peer.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L3RjaGFubmVsL3BlZXIuZ28=) | `97.36% <0.00%> (+1.31%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.