yarpc / yarpc-go

A message passing platform for Go
MIT License
405 stars 103 forks source link

http: explicitly set and use http client in outbound #2175

Closed jronak closed 1 year ago

jronak commented 2 years ago

HTTP outbound now uses the http.Client explicitly set on the outbound struct than reading the client from yarpc HTTP transport. This is a minor cleanup done which is used in the HTTP outbound TLS integration where each outbound gets a separate HTTP client to do mTLS.

codecov[bot] commented 2 years ago

Codecov Report

Base: 85.23% // Head: 85.25% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (d7b9182) compared to base (cca6727). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2175 +/- ## ========================================== + Coverage 85.23% 85.25% +0.02% ========================================== Files 269 269 Lines 15352 15353 +1 ========================================== + Hits 13085 13089 +4 + Misses 1846 1844 -2 + Partials 421 420 -1 ``` | [Impacted Files](https://codecov.io/gh/yarpc/yarpc-go/pull/2175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc) | Coverage Δ | | |---|---|---| | [transport/http/outbound.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2175/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L2h0dHAvb3V0Ym91bmQuZ28=) | `92.09% <100.00%> (+0.02%)` | :arrow_up: | | [transport/internal/tls/dialer/dialer.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2175/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L2ludGVybmFsL3Rscy9kaWFsZXIvZGlhbGVyLmdv) | `100.00% <0.00%> (+8.82%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.