yarpc / yarpc-go

A message passing platform for Go
MIT License
401 stars 101 forks source link

[WIP]Upgraded grpc-go to 1.40.1 #2180

Closed gandhikrishna closed 1 year ago

gandhikrishna commented 1 year ago
jronak commented 1 year ago

Lint fails on deprecated usage of grpc.CustomCodec but this will be supported throughout 1.x of gRPC-go. To unblock this, add lint ignore directive above https://github.com/yarpc/yarpc-go/blob/dev/transport/grpc/inbound.go#L118 like:

    handler := newHandler(i, i.t.options.logger)

    serverOptions := []grpc.ServerOption{
                //lint:ignore SA1019 explicit use of customCodec and it is available throughout 1.x of grpc-go
        grpc.CustomCodec(customCodec{}),
        grpc.UnknownServiceHandler(handler.handle),