codecov[bot]
commented
1 year ago Codecov Report
Base: 85.27% // Head: 85.27% // Increases project coverage by +0.00% :tada:
Coverage data is based on head (
b8d68d8) compared to base (e1afd5b). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## dev #2181 +/- ## ======================================= Coverage 85.27% 85.27% ======================================= Files 269 269 Lines 15399 15397 -2 ======================================= - Hits 13131 13130 -1 Misses 1846 1846 + Partials 422 421 -1 ``` | [Impacted Files](https://codecov.io/gh/yarpc/yarpc-go/pull/2181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc) | Coverage Δ | | |---|---|---| | [transport/tchannel/transport.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2181/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L3RjaGFubmVsL3RyYW5zcG9ydC5nbw==) | `86.46% <ø> (-0.59%)` | :arrow_down: | | [transport/tchannel/outbound.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2181/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L3RjaGFubmVsL291dGJvdW5kLmdv) | `77.02% <100.00%> (-0.31%)` | :arrow_down: | | [transport/tchannel/peer.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2181/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L3RjaGFubmVsL3BlZXIuZ28=) | `97.56% <100.00%> (+1.50%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This pull request refactors the tchannel peer to expose its
tchannel.Peer, exposes the root peer list from the transport channel, and refactorsoutbound.Callto use peer exposed methods for fetchingtchannel.Peer. This is done to avoidoutbound.gofrom accessingtransport.chdirectly in theCallmethod, as in the following PR a peer might be created from a differenttchannel.Channel