search

yarpc / yarpc-go

A message passing platform for Go
MIT License
401 stars 101 forks source link

Log original context deadline on errors (#2184) #2185

Closed jquirke closed 1 year ago

jquirke commented 1 year ago

Log original context deadline, if available, which is particularly useful on failed calls where the caller has supplied an unreasonably short deadline.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

jquirke commented 1 year ago

retrying in a new PR #2186

codecov[bot] commented 1 year ago

Codecov Report

Base: 85.28% // Head: 85.27% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (c5828bb) compared to base (792f032). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2185 +/- ## ========================================== - Coverage 85.28% 85.27% -0.02% ========================================== Files 269 269 Lines 15397 15399 +2 ========================================== - Hits 13132 13131 -1 - Misses 1845 1846 +1 - Partials 420 422 +2 ``` | [Impacted Files](https://codecov.io/gh/yarpc/yarpc-go/pull/2185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc) | Coverage Δ | | |---|---|---| | [internal/observability/call.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-aW50ZXJuYWwvb2JzZXJ2YWJpbGl0eS9jYWxsLmdv) | `94.06% <100.00%> (+0.05%)` | :arrow_up: | | [dispatcher\_startup.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-ZGlzcGF0Y2hlcl9zdGFydHVwLmdv) | `91.07% <0.00%> (-1.79%)` | :arrow_down: | | [transport/tchannel/peer.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L3RjaGFubmVsL3BlZXIuZ28=) | `96.05% <0.00%> (-1.32%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.