yarpc / yarpc-go

A message passing platform for Go
MIT License
401 stars 101 forks source link

http mtls: add tls decoder in oneway configurator #2193

Closed jronak closed 1 year ago

jronak commented 1 year ago

TLS decoder must be provided for oneway outbound configurator as oneway is supported in tchannel and HTTP outbounds.

codecov[bot] commented 1 year ago

Codecov Report

Base: 85.33% // Head: 85.31% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (400b7c2) compared to base (ee2f1d3). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2193 +/- ## ========================================== - Coverage 85.33% 85.31% -0.02% ========================================== Files 270 270 Lines 15463 15463 ========================================== - Hits 13195 13193 -2 - Misses 1846 1847 +1 - Partials 422 423 +1 ``` | [Impacted Files](https://codecov.io/gh/yarpc/yarpc-go/pull/2193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc) | Coverage Δ | | |---|---|---| | [transport/tchannel/transport.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L3RjaGFubmVsL3RyYW5zcG9ydC5nbw==) | `87.42% <ø> (ø)` | | | [yarpcconfig/builder.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-eWFycGNjb25maWcvYnVpbGRlci5nbw==) | `98.77% <100.00%> (ø)` | | | [peer/hashring32/internal/hashring32/hashring32.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-cGVlci9oYXNocmluZzMyL2ludGVybmFsL2hhc2hyaW5nMzIvaGFzaHJpbmczMi5nbw==) | `96.21% <0.00%> (-1.09%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.