Closed DheerendraRathor closed 1 year ago
Patch coverage: 50.00
% and project coverage change: -0.01
:warning:
Comparison is base (
e3ff3d8
) 85.35% compared to head (5c18790
) 85.34%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
In
serveConnection
, closing the muxed connection instead of underlyingnet.Conn
to properly release resources. Muxed connection can be*tls.Conn
and should be closed properly.Other minor change is close the
stoppedChan
inserve
at the end as closing it will unblock read inClose
and will effectively close the listener. This should be the last logical instruction during close.