codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 83.33% and project coverage change: +0.01 :tada:
Comparison is base (
a74f654) 85.33% compared to head (12496e0) 85.34%.:exclamation: Current head 12496e0 differs from pull request most recent head 22d4869. Consider uploading reports for the commit 22d4869 to get more accurate results
Additional details and impacted files
```diff @@ Coverage Diff @@ ## dev #2207 +/- ## ========================================== + Coverage 85.33% 85.34% +0.01% ========================================== Files 270 270 Lines 15475 15479 +4 ========================================== + Hits 13205 13210 +5 Misses 1847 1847 + Partials 423 422 -1 ``` | [Impacted Files](https://codecov.io/gh/yarpc/yarpc-go/pull/2207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc) | Coverage Δ | | |---|---|---| | [transport/internal/tls/muxlistener/listener.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L2ludGVybmFsL3Rscy9tdXhsaXN0ZW5lci9saXN0ZW5lci5nbw==) | `92.15% <80.00%> (-1.73%)` | :arrow_down: | | [transport/internal/tls/muxlistener/tls\_checker.go](https://codecov.io/gh/yarpc/yarpc-go/pull/2207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc#diff-dHJhbnNwb3J0L2ludGVybmFsL3Rscy9tdXhsaXN0ZW5lci90bHNfY2hlY2tlci5nbw==) | `100.00% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://codecov.io/gh/yarpc/yarpc-go/pull/2207/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yarpc):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
We currently log them at error level, moving them to warn seems appropriate as they are not server failures in themselves and client is terminating connection.
Keeping them logged so we can still debug failures and monitor them.
Another change is minor improvement in
isTLSClientHelloRecordto reduce allocations by using an array instead of slice for temp buffer.