search

yarpc / yarpc-go

A message passing platform for Go
MIT License
401 stars 101 forks source link

[WIP] Wrong func argument is internal error #2269

Open biosvs opened 2 months ago

biosvs commented 2 months ago

Depends on #2251

Invalid argument passed to a function doesn't mean that we should return InvalidArgument error. For those cases we should return InternalError, because client can't fix this problem by changing request.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.22%. Comparing base (23c069f) to head (6fa8d16).

Files Patch % Lines
api/transport/stream.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2269 +/- ## ========================================== - Coverage 85.23% 85.22% -0.02% ========================================== Files 270 270 Lines 15555 15557 +2 ========================================== Hits 13258 13258 Misses 1876 1876 - Partials 421 423 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.