search

yarpc / yarpc-go

A message passing platform for Go
MIT License
401 stars 101 forks source link

[1/2 tchannel refactoring] Extracted response writer to dedicated file. #2273

Open biosvs opened 1 month ago

biosvs commented 1 month ago

Extracted response writer to dedicated file, introduced constructor type and simplified interface.

This PR is part of header handling changes (https://github.com/yarpc/yarpc-go/issues/2265). This refactoring was extracted from tchannel PR to make review easier.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 82.89474% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 85.30%. Comparing base (f7b3c8e) to head (1d693b7).

Files Patch % Lines
transport/tchannel/response_writer.go 78.68% 7 Missing and 6 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## emit-metrics-for-new-behavior-step-1 #2273 +/- ## ======================================================================== - Coverage 85.33% 85.30% -0.04% ======================================================================== Files 271 272 +1 Lines 15624 15632 +8 ======================================================================== + Hits 13333 13335 +2 - Misses 1872 1875 +3 - Partials 419 422 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.