search

yarpc / yarpc-go

A message passing platform for Go
MIT License
401 stars 101 forks source link

Question on mocks #2281

Open 3vilhamster opened 1 week ago

3vilhamster commented 1 week ago

Hey folks, last summer, https://github.com/golang/mock became read-only, and all users are advised to update to go.uber.org/mock for mock generation.

As far as I understand, this will be a breaking change in the current yarpc implementation, but I would like to know if there are plans to update it. We have to create two separate controllers to handle mocks, which is imperfect.

It should be a noop change, though all users will have to regenerate mocks and update tests.

biosvs commented 1 week ago

There's an open PR #2236, we just not ready to land it yet, as we're busy with the grpc-go upgrade.

We'll think about cutting a "technical" release to include some safe PRs without behaviour changes. Hopefully it'll be done until the end of summer.