search

yarpc / yarpc-go

A message passing platform for Go
MIT License
405 stars 103 forks source link

Move transport.Ack up #556

Closed HelloGrayson closed 7 years ago

HelloGrayson commented 7 years ago

This is a main shape used by service authors in their oneway handlers, let's move it to yarpc.Ack.

willhug commented 7 years ago

with the api rewrite this is in /api/transport/ack is that reasonable?

willhug commented 7 years ago

wait, right, used by caller/callees, I got this.

willhug commented 7 years ago

hmmmmmmmmmmmmmmmmmmmmmmmmm so since the dispatcher imports the /transport/ api, and transport uses the ack object we won't be able to move it to yarpc.Ack

We caaaaaan create an external version of the yarpc.Ack (similar to the external versions of Req/Res)

willhug commented 7 years ago

Also the dispatcher level does not use the ack object, it only gets returned based on the encoding/transport.