search

yarpc / yarpc-go

A message passing platform for Go
MIT License
412 stars 103 forks source link

ThriftRW Plugin: Lower case argument names in generated interfaces #590

Closed abhinav closed 6 years ago

abhinav commented 7 years ago

Server and client interfaces use upper cased parameter names for service methods.

https://github.com/yarpc/yarpc-go/blob/fdbad937b763e420178cde657f4de8b1dffaf115/internal/examples/thrift-keyvalue/keyvalue/kv/keyvalueserver/server.go#L43-L44

These should be lower cased or the name from the Thrift file should be used.

kriskowal commented 7 years ago

This issue has gone stale and I expect we can’t do anything about it post-1.0. Please advise/close.

abhinav commented 7 years ago

We can do this post-1.0. It's just parameter names in the generated interfaces. That's actually why we pushed it to post-1.0 rather than doing it earlier.

abhinav commented 7 years ago

Still an issue

bufdev commented 6 years ago

Are we ever going to fix this? I think we might want to just mark as "wontfix" because the effort here is decent (I remember looking into it) without much upside.

abhinav commented 6 years ago

Closing as wontfix. This doesn't have any behavioral consequences. We can revive this if someone has time to work on it.