search

yaseenkadir / etchedjournal

An encrypted journal where entries are etched in stone.
Apache License 2.0
0 stars 0 forks source link

Added logout functionality #76

Closed yaseenkadir closed 5 years ago

yaseenkadir commented 5 years ago

Fixes #75

yaseenkadir commented 5 years ago

I decided to keep this fix pretty minimal. When you logout, it just clears the tokens from local storage. There is no network request. As a common user I would think something went wrong if the logout was that slow.

I thought to fix that problem we should just refresh the page but it doesn't look so easy with angular 5+. There used to exist Location#reload() (on the Location provided by Angular) but that's not there anymore. location.reload() exists (NOTE: lower case l). I feel like there should be a way via angular, but if not we can just use that hack later.

I also considered adding a fake logout spinner with a delay. But realised that it's not worth it right now. We can figure out the actual solution later. Lets just get log out added for now.