Closed jacekziembla closed 4 months ago
@yashaka apologizes that I did not create issue first, should be linked now. I edited it via GitHub UI without cloning and did not run mypy check as well - although the change is really tiny (I've checked if it's working by editing directly source files in my venv)
based on the linters and tests, I guess it should be smth like
message=getattr(reason, "msg", None)
I have run black locally, this check should be passing now. There are ~5 tests that needs to be fixed, as the reason string changed and we do not have 'Stacktrace: *',
now, but I was unable to kick these tests locally without browserstack key
I have run black locally, this check should be passing now. There are ~5 tests that needs to be fixed, as the reason string changed and we do not have
'Stacktrace: *',
now, but I was unable to kick these tests locally without browserstack key
Modified error_messages tests, also in case there is no original error message we fallback to previous behavior of casting the error to string
Modified error_messages tests, also in case there is no original error message we fallback to previous behavior of casting the error to string
yes, this was something that I felt was absent... great that you found it!
Great, thanks! Waiting for next release 🤞
Currently we were casting entire exception to the string (including not readable stacktrace) from selenium to error message. Instead, we should pass just the error message.
Before:
After: