yashakhoshini / yasha-fastpages

Apache License 2.0
1 stars 2 forks source link

Week 19 review ticket #21

Open yashakhoshini opened 1 year ago

yashakhoshini commented 1 year ago
jm1021 commented 1 year ago

On 1st model hacks, I like the use of stock names ["AAPL", "MSFT", "UNK"]. This shows understanding. But I am not sure you would use classOf in your project.

In managing definitions I would not dedicate an entire blog to OOP terms, you should be managing that with other definitions that we did last tri, but I like the thought.

Scoring exercise does not exhibit any learning on your part. Check boxes would be much more effective with summary. If you want CB definitions you should have them once on the page. This is unreadable as it is and has now meaning.

JakeWarren2414 commented 1 year ago

3/3