✅ Feature: Landmark Detection from Images

yashksaini-coder commented 1 month ago

Description

This PR introduces a new landmark detection feature, including form configuration, model prediction, and page rendering. The most important changes include adding a new form configuration for landmark detection, implementing the prediction logic using TensorFlow, and updating the page configuration to render the new feature.

Landmark Detection Feature:

form_configs/landmark_detection.json: Added a new form configuration to handle image uploads for landmark detection.
models/landmark_detection/predict.py: Implemented the prediction logic using TensorFlow and TensorFlow Hub for landmark classification.
pages/pages.json: Updated the page configuration to include the new landmark detection page and link it to the form and prediction logic.

Page Rendering:

pages/Landmark_Detection.py: Added code to render the landmark detection page using the PageHandler class.

Development Environment:

.vscode/settings.json: Added newaxis to the list of recognized words in the spell checker configuration.

Issue Resolved

✅ Fixes #134

Changes Made

I created & updated the files following the guidelines & steps mentioned in the project-structure.md Also there were few issues I encountered in the page-handler.py file

Screenshots or Videos

predictive-calc-134.webm

Additional Details

Yeah so, this is the first web app in this predictive-calc that is image-processing based, with open source model, so can this be considered as level 3

Checklist

[X] My code follows the current project structure
[X] I have thoroughly reviewed and updated the requirements.txt file to include any new packages
[X] The predict.py file includes a properly implemented model_details() function, or the notebook contains this function to print a detailed model report. The model will not be accepted without this function, as it is essential for generating the necessary model details.
[x] I have added relevant tests (if necessary).
[X] I have added comments in the code where needed.
[X] This PR is submitted under Hacktoberfest.
[X] This PR is submitted under GirlScript Summer of Code (GSSoC-Extd).

yashksaini-coder commented 1 month ago

@yashasvini121 review this PR and add proper labels for hacktoberfest & gssoc

yashksaini-coder commented 1 month ago

@yashasvini121 Also do you have a discord channel that I can join.

yashksaini-coder commented 1 month ago

Hi @yashasvini121 can you assign me on this PR with proper gssoc & hacktoberfest labels

yashksaini-coder commented 1 month ago

@yashasvini121 is the review still going on ?

yashasvini121 commented 1 month ago

Hi, there's a power cut in my area, so I'll continue tomorrow. Your code looks correct, and I'll merge it tomorrow unless any changes are needed.

yashksaini-coder commented 1 month ago

Hi, there's a power cut in my area, so I'll continue tomorrow. Your code looks correct, and I'll merge it tomorrow unless any changes are needed.

No worries I was checking to get an update if there were any changes you wanted as PR was idle for a time

yashasvini121 commented 1 month ago

And I accidentally deleted the .gitignore. Feel free to recreate it just be sure not to include your env. If not, I’ll add it back myself tomm.

yashksaini-coder commented 1 month ago

And I accidentally deleted the .gitignore. Feel free to recreate it just be sure not to include your env. If not, I’ll add it back myself tomm.

no worries, your idea is really good, I have worked on streamlit web apps before but never saw this structure.

Just merge this PR if you are satisfied @yashasvini121

yashksaini-coder commented 1 month ago

@yashasvini121 also assign me on this issue

yashksaini-coder commented 1 month ago

hey why U removed the labels @yashasvini121

yashasvini121 commented 1 month ago

You need to test and update the requirements.txt file accordingly, currently the site isn't working because of package version issues. Fix that first.

yashasvini121 commented 1 month ago

Test the whole app locally first

yashksaini-coder commented 1 month ago

okh then I will update the code, but this PR is merged already, should i push ed the code in this branch directly, Or raise a new PR

yashasvini121 commented 1 month ago

create a new pr, and link the same issue

yashksaini-coder commented 1 month ago

Hi @yashasvini121 there are dependency conflicts for other web app requirements, if I changes dependency for mine.

yashksaini-coder commented 1 month ago

In such case I can create a new requirements.txt that can be used for image or TensorFlow based web-apps. @yashasvini121 I am going with this approach.

yashasvini121 commented 1 month ago

No, that won't work because Streamlit Cloud expects a single requirements.txt file.

yashksaini-coder commented 1 month ago

No, that won't work because Streamlit Cloud expects a single requirements.txt file.

then what should I do, if i upgrade dependencies for my web-app then others may run into issues @yashasvini121

yashksaini-coder commented 1 month ago

@yashasvini121 i have raised a PR #164 check it out.

yashksaini-coder commented 1 month ago

@yashasvini121 add proper labels on this issue please

yashasvini121 commented 1 month ago

Sorry but this pr won't count, I have added labels on the new one. You can work on this afresh if you want.

yashksaini-coder commented 1 month ago

Sorry but this pr won't count, I have added labels on the new one. You can work on this afresh if you want.

no worries also add on the issue it is also checked with PR

yashasvini121 / predictive-calc