yashchaudhari008 / minime

Minimal Homepage | Streamlined, Stylish, Simple.
https://yashchaudhari008.github.io/minime/
MIT License
14 stars 14 forks source link

[FEATURE] : Footer component #8

Closed linyers closed 9 months ago

linyers commented 9 months ago

New feature for issue https://github.com/yashchaudhari008/minime/issues/7

Contain:

2024-01-27-104804_649x62_scrot

yashchaudhari008 commented 9 months ago

Thanks for contributing.

Please mention yourself on the issue, so that I can assign it to you

linyers commented 9 months ago

While making the changes, I encountered a bug with the font-weight of the Inter font. I was able to resolve it, but I'm unsure whether to include it in this pull request or create a new one.

yashchaudhari008 commented 9 months ago

@linyers What's the exact issue?

linyers commented 9 months ago

The issue was with the Inter font. When attempting to increase the weight of the Inter font, it remained at the default (400). I also noticed that certain components were using a different weight than the default, and the weight stayed at 400 even when set to 800. So, I imported various weights for the Inter font, and the issue was resolved.

in src/index.scss @import url("https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700;800;900...");

yashchaudhari008 commented 9 months ago

Can you check whether this happens only when Chrome is opened in incognito mode? Because this is happening in my case!

yashchaudhari008 commented 9 months ago

Also, can you push your recent changes and request re-review?

linyers commented 9 months ago

Can you check whether this happens only when Chrome is opened in incognito mode? Because this is happening in my case!

I have been noticing that this seems to be some issue with browsers. I tested it on Chrome, Brave, and Firefox. I'm sharing some links that discuss this:

https://stackoverflow.com/questions/22001035/font-weight-ignored-in-chrome https://github.com/tailwindlabs/tailwindcss/issues/1402

I have tried different solutions, and the one that worked for me was importing the weights I am going to use:

@import url("http://fonts.googleapis.com/css?family=Open+Sans:400,300,500,800");