search

yashima / droidweight

Automatically exported from code.google.com/p/droidweight
1 stars 4 forks source link

Code review request #9

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Repo: https://code.google.com/r/blokeley-custom-date-support

Branch name: default

Purpose of code changes on this branch: partially fixes issue 8 (custom date 
support).

When reviewing my code changes, please focus on why the list view on the 
MeasureActivity does not update after an existing measurement has had the date 
changed.

If the work is useful, please pull it to the main droidweight repo. We can then 
work on fixing the list view update after an existing measurement has had the 
date changed.

Original issue reported on code.google.com by blokeley@gmail.com on 9 Apr 2012 at 5:30

GoogleCodeExporter commented 9 years ago 
I had totally forgotten about this, when I made my last few changes. The 
MeasureEdit Activity was in dire need of improvement and while I was there I 
added the dialogs as you had suggested and came to quite a similar solution. I 
am so sorry about ignoring this. (Still having trouble with Mercurial, though I 
can commit stuff now).

Original comment by yash...@gmail.com on 13 Dec 2012 at 2:53

GoogleCodeExporter commented 9 years ago 
The code looked very similar to mine. I cannot put my thumb on why the update 
didn't work on the list view. Mine does. Sorry again for overlooking all the 
branches.

Original comment by yash...@gmail.com on 21 Dec 2012 at 11:13