search

yashodgayashan / environment_platform

A comprehensive online request management platform for the Ministry of Environment and Wildlife Resources, Sri Lanka
Apache License 2.0
6 stars 4 forks source link

Added saveApplication function #17

Closed yashodgayashan closed 4 years ago

yashodgayashan commented 4 years ago

Could you please comment on this function. This function first convert the TreeRemovalForm into a form which is suitable for the database and insert it to the database. Thought of break this function to two which are postApplicationToDB and convertPostApplication.

deshankoswatte commented 4 years ago

@yashodgayashan did you run a ballerina format? if not please run that too.

yashodgayashan commented 4 years ago

@yashodgayashan did you run a ballerina format? if not please run that too.

I format the code before committing.

yashodgayashan commented 4 years ago

Could you please comment on this function. This function first convert the TreeRemovalForm into a form which is suitable for the database and insert it to the database. Thought of break this function to two which are postApplicationToDB and convertPostApplication.

@deshankoswatte @sanjulamadurapperuma What do you think about this?

sanjulamadurapperuma commented 4 years ago

Could you please comment on this function. This function first convert the TreeRemovalForm into a form which is suitable for the database and insert it to the database. Thought of break this function to two which are postApplicationToDB and convertPostApplication.

@deshankoswatte @sanjulamadurapperuma What do you think about this?

Yeah we could do this. But better make the names of those functions easier to understand.

sanjulamadurapperuma commented 4 years ago

@vikumkbv is there anything we missed?

deshankoswatte commented 4 years ago

Could you please comment on this function. This function first convert the TreeRemovalForm into a form which is suitable for the database and insert it to the database. Thought of break this function to two which are postApplicationToDB and convertPostApplication.

@deshankoswatte @sanjulamadurapperuma What do you think about this?

Yeah we could do this. But better make the names of those functions easier to understand.

@yashodgayashan pls proceed with methods and also consider @sanjulamadurapperuma suggestions. @vikumkbv your thoughts would also be appreciated on this.

yashodgayashan commented 4 years ago

Requested minor changes. @deshankoswatte resolved minor changes.

vikumkbv commented 4 years ago

Looks good to me for now

Same for me