Closed yashodgayashan closed 4 years ago
@yashodgayashan did you run a ballerina format
? if not please run that too.
@yashodgayashan did you run a
ballerina format
? if not please run that too.
I format the code before committing.
Could you please comment on this function. This function first convert the TreeRemovalForm into a form which is suitable for the database and insert it to the database. Thought of break this function to two which are postApplicationToDB and convertPostApplication.
@deshankoswatte @sanjulamadurapperuma What do you think about this?
Could you please comment on this function. This function first convert the TreeRemovalForm into a form which is suitable for the database and insert it to the database. Thought of break this function to two which are postApplicationToDB and convertPostApplication.
@deshankoswatte @sanjulamadurapperuma What do you think about this?
Yeah we could do this. But better make the names of those functions easier to understand.
@vikumkbv is there anything we missed?
Could you please comment on this function. This function first convert the TreeRemovalForm into a form which is suitable for the database and insert it to the database. Thought of break this function to two which are postApplicationToDB and convertPostApplication.
@deshankoswatte @sanjulamadurapperuma What do you think about this?
Yeah we could do this. But better make the names of those functions easier to understand.
@yashodgayashan pls proceed with methods and also consider @sanjulamadurapperuma suggestions. @vikumkbv your thoughts would also be appreciated on this.
Requested minor changes. @deshankoswatte resolved minor changes.
Looks good to me for now
Same for me
Could you please comment on this function. This function first convert the TreeRemovalForm into a form which is suitable for the database and insert it to the database. Thought of break this function to two which are postApplicationToDB and convertPostApplication.