Minor formatting changes

yashodgayashan / environment_platform

A comprehensive online request management platform for the Ministry of Environment and Wildlife Resources, Sri Lanka

Apache License 2.0

6 stars 4 forks source link

Minor formatting changes #19

Closed deshankoswatte closed 4 years ago

deshankoswatte commented 4 years ago

Re initiation of https://github.com/yashodgayashan/environment_platform/pull/18 with most of the suggestions added.
Added TODOs for return values and debug logs, this is due to the fact that there are some problems with MongoDB client and it shows errors in my editor.

deshankoswatte commented 4 years ago

@yashodgayashan & @vikumkbv thoughts?

deshankoswatte commented 4 years ago

Fixed TODOs for return values of methods saveApplication and deleteApplication. Now these method will wither return a boolean or an error. Only debug logs are now required I think we should discuss about that offline first and then put another PR for that.

yashodgayashan commented 4 years ago

Fixed TODOs for return values of methods saveApplication and deleteApplication. Now these method will wither return a boolean or an error. Only debug logs are now required I think we should discuss about that offline first and then put another PR for that.

Looks good to me.

yashodgayashan commented 4 years ago

@sanjulamadurapperuma I have committed requested changes

deshankoswatte commented 4 years ago

@sanjulamadurapperuma Please approve.