yashodgayashan / environment_platform

A comprehensive online request management platform for the Ministry of Environment and Wildlife Resources, Sri Lanka
Apache License 2.0
6 stars 4 forks source link

Developed resource functions and support db function. #44

Closed yashodgayashan closed 4 years ago

yashodgayashan commented 4 years ago

Resource functions developed

yashodgayashan commented 4 years ago

@sanjulamadurapperuma @vikumkbv @deshankoswatte Please review this

sanjulamadurapperuma commented 4 years ago

@vikumkbv Please review and see if we missed anything.

deshankoswatte commented 4 years ago

@yashodgayashan we need to see the character count of a code line too.

yashodgayashan commented 4 years ago

@yashodgayashan we need to see the character count of a code line too.

I didn't get it

deshankoswatte commented 4 years ago

@yashodgayashan we need to see the character count of a code line too.

I didn't get it

I mean the length of the code line @yashodgayashan

yashodgayashan commented 4 years ago

@yashodgayashan we need to see the character count of a code line too.

I didn't get it

I mean the length of the code line @yashodgayashan

mmm What should be the limit?

deshankoswatte commented 4 years ago

@yashodgayashan we need to see the character count of a code line too.

I didn't get it

I mean the length of the code line @yashodgayashan

mmm What should be the limit?

I think 120 characters @sanjulamadurapperuma @vikumkbv please confirm.

vikumkbv commented 4 years ago

@yashodgayashan we need to see the character count of a code line too.

I didn't get it

I mean the length of the code line @yashodgayashan

mmm What should be the limit?

I think 120 characters @sanjulamadurapperuma @vikumkbv please confirm.

Yes we have format the code normally 120 is the length

sanjulamadurapperuma commented 4 years ago

@yashodgayashan we need to see the character count of a code line too.

I didn't get it

I mean the length of the code line @yashodgayashan

mmm What should be the limit?

I think 120 characters @sanjulamadurapperuma @vikumkbv please confirm.

Yes we have format the code normally 120 is the length

There is no hard and fast rule saying that we must limit line length, but there is no harm in doing so from the developer's perspective. 120 is fine for the limit.

yashodgayashan commented 4 years ago

I will update this code by tonight

yashodgayashan commented 4 years ago

Resolved requested changes. Please review the changes @deshankoswatte @sanjulamadurapperuma @vikumkbv

yashodgayashan commented 4 years ago

@deshankoswatte Resolved requested changes.

yashodgayashan commented 4 years ago

@sanjulamadurapperuma waiting for your review and approval

deshankoswatte commented 4 years ago

From next time onwards let's squash code formatting changes into 1 commit. @yashodgayashan, @sanjulamadurapperuma, @vikumkbv thoughts?