Closed yashodgayashan closed 4 years ago
@sanjulamadurapperuma @vikumkbv @deshankoswatte Please review this
@vikumkbv Please review and see if we missed anything.
@yashodgayashan we need to see the character count of a code line too.
@yashodgayashan we need to see the character count of a code line too.
I didn't get it
@yashodgayashan we need to see the character count of a code line too.
I didn't get it
I mean the length of the code line @yashodgayashan
@yashodgayashan we need to see the character count of a code line too.
I didn't get it
I mean the length of the code line @yashodgayashan
mmm What should be the limit?
@yashodgayashan we need to see the character count of a code line too.
I didn't get it
I mean the length of the code line @yashodgayashan
mmm What should be the limit?
I think 120 characters @sanjulamadurapperuma @vikumkbv please confirm.
@yashodgayashan we need to see the character count of a code line too.
I didn't get it
I mean the length of the code line @yashodgayashan
mmm What should be the limit?
I think 120 characters @sanjulamadurapperuma @vikumkbv please confirm.
Yes we have format the code normally 120 is the length
@yashodgayashan we need to see the character count of a code line too.
I didn't get it
I mean the length of the code line @yashodgayashan
mmm What should be the limit?
I think 120 characters @sanjulamadurapperuma @vikumkbv please confirm.
Yes we have format the code normally 120 is the length
There is no hard and fast rule saying that we must limit line length, but there is no harm in doing so from the developer's perspective. 120 is fine for the limit.
I will update this code by tonight
Resolved requested changes. Please review the changes @deshankoswatte @sanjulamadurapperuma @vikumkbv
@deshankoswatte Resolved requested changes.
@sanjulamadurapperuma waiting for your review and approval
From next time onwards let's squash code formatting changes into 1 commit. @yashodgayashan, @sanjulamadurapperuma, @vikumkbv thoughts?
Resource functions developed