search

yashpola / pe

0 stars 0 forks source link

Unnecessary association between `JsonAdaptedPerson` and `JsonAdaptedTag` in `Storage` component in DG #10

Open yashpola opened 2 months ago

yashpola commented 2 months ago

Description

The Storage component diagram in the DG suggests an any-amount association from JsonAdaptedPerson to JsonAdaptedTag. However, there is no evidence of this in the code, leading me to believe there is a wrong association between the two classes. Moreover, there is an any-amount association from JsonSerializableAddressBook to JsonAdaptedPerson which is in-fact visible in the code. This makes the unnecessary association from JsonAdaptedPerson to JsonAdaptedTag more inconsistent.

DG Diagram

image.png

Code (JsonAdaptedPerson)

image.png

Code ('JsonSerializableAddressBook`)

This is what I was looking for in JsonAdaptedPerson (but for Tag):

image.png

soc-pe-bot commented 2 months ago

Your response not required for this bug as the team has accepted the bug as it is.