yashrathi-git / vimeo-dl

Downloads Vimeo videos and retrieve metadata such as views, likes, comments, duration of the video.
MIT License
66 stars 16 forks source link

#3 Reading by default the video title #3

Closed bhanuunrivalled closed 3 years ago

bhanuunrivalled commented 3 years ago

HI @yashrathi-git ,

This is a feature that helped me to get the file name from the JSON.

maybe it will be useful for others also.

I am reading the video title as below

js_url["video"]["title"].

Will be glad if it helps :)

Thanks.

yashrathi-git commented 3 years ago

Sorry, for late reply Thanks for PR. It is really helpful. It should have been, default behavior. I am not merging this because it exposes get_title method, but it was not needed here and the users of module can't use the method and title could be an instance attribute. So I made required changes myself as there weren't many changes to make. Thanks!