yashshah1 / abuu

A collection of my utils [WIP]
MIT License
2 stars 5 forks source link

Added setup.py for deployment to pypi, install twine and push it to PyPI #7

Closed abhirambsn closed 4 years ago

abhirambsn commented 4 years ago

No description provided.

Added the required setup.py file for pypi deployment, kindly edit details according to you (eg. email, name of package, etc.)

Issue #5

Regards, Abhiram BSN

yashshah1 commented 4 years ago

@abhirambsn Hi, This is amazing work, Thank you so much. However, is it possible for you to make it a little more configurable? The packages has an entry utils.pandas. Is there a way to not have that change every time we add a folder to the package?

For example, now there are 2 other folders. Is adding only utils not enough?

abhirambsn commented 4 years ago

@abhirambsn Hi, This is amazing work, Thank you so much. However, is it possible for you to make it a little more configurable? The packages has an entry utils.pandas. Is there a way to not have that change every time we add a folder to the package?

For example, now there are 2 other folders. Is adding only utils not enough?

Actually you can add the folders to the packages list like if you add tools folder then you can add the folder name after the utils folder

yashshah1 commented 4 years ago

But that would require me to keep adding to the list after every folder is added, can we do without it? I took a look at this and he does something with find_packages() can we use that?

abhirambsn commented 4 years ago

Actually in the find_packages() function you need to specify the directory of the libraries, by default it searches in the current directory, but if in near future you want a nested package inside your utils directory then it will create issues, so thats why I went with this method,

But if you want I can change the file accordingly

yashshah1 commented 4 years ago

Hi, so two things: 1) Why can't we move setup.py to the root folder? If done like that, we would lose the need of adding a ../ to the path and 2) using find_packages() without any params would also work given that we only need to export abuu which is a directory in the same path that setup.py lives. Also, abuu/__init__.py exists so I'm assuming any doc/examples folder I decide to add later won't be exported along side given that we won't have a __init__.py file in that folder

abhirambsn commented 4 years ago

Then you need to add an init.py to the repository root

abhirambsn commented 4 years ago

If you say I will take care of that

yashshah1 commented 4 years ago

Are you sure, a lot of projects out there have a directory with the name of the package inside the repo. See this and this.

But even if that is the case, I prefer having the setup.py outside of where the code lives, given that it isn't doing any logic, but just the setting up of the code.

Also, I've just done a little refactoring, please merge before pushing

abhirambsn commented 4 years ago

So you tell me what should I do, should I modify the setup.py or should I leave it as it is, see, If you add any new package inside utils directory and add that to utils/_ init _.py it will be automatically added by my version of setup.py, if you add any folder outside of utils directory then you need to add the directory name, so you tell me what should be my further actions on this issue

yashshah1 commented 4 years ago

I've refactored to remove the utils directory. So now I just have one directory, inside which all the folders live. So ideally, get the setup.py to the root of this repository, and change the package list to have only [abuu] or use find_packages()

abhirambsn commented 4 years ago

I have modified the setup.py, if you face any problems comment me

yashshah1 commented 4 years ago

Thank you!

abhirambsn commented 4 years ago

Thank you!

Mention not, it was fun actually