Closed jklebes closed 3 months ago
Thank @jklebes for bringing it to my attention. I will look into it and if you want I can assign it to you :)
You can assign me. But how do you run your unit tests? hatch test test/test.py
didn't do it.
Hey @jklebes, sorry to be late I'll assign you for this :)
As for the test I don't think it works anymore as wikipedia contents changes time on time it would be hard to implement any direct assertion. Still the script does not run as it is not in actual test format and there were addition of unicode color in the text which just breaks it entirely.
The codebase is very messy so good luck.
I did write a new test and it should work for now :)
Yes the "Lahore" case works now / bug can't be reproduced, even without changing the code. Something changed on wikipedia. <p style="padding-bottom: 0em;"></p>
is no longer in the html source. I'll fix it when I find another broken example to test.
Sure :+1:
I'm closing it for now. If in future you face anything similar feel free to reopen it again or you can create a new issue.
Nice software.
wik -i Lahore
gets meThis section of content at the bottom of the box
is turned into a zero-length string.