search

yasinkacmaz / jetflix

Movie listing app using Jetpack Compose and Tmdb api
MIT License
403 stars 39 forks source link

Feature request: add search #195

Closed Pauler221 closed 2 years ago

Pauler221 commented 2 years ago

It would be really nice to be able so search for a movie name. Otherwise great app!

yasinkacmaz commented 2 years ago

Hello @Pauler221 thanks for the feedback. I tried integrating search in this app. I even have a branch here: feat/search The thing is TMDB discover endpoint didn't have query parameter at that time. I have a commit with this message: BLOCKED (You cannot have query parameter at tmdb discover endpoint)

I will read TMDB API documentation more and will inform you if there is another way around.

Didiloy commented 2 years ago

Hello @yasinkacmaz thanks for your comitment. The search function is also something I will love to see. I think maybe this endpoint https://developers.themoviedb.org/3/search/search-movies is what you are looking for ? Keep up the good work !

yasinkacmaz commented 2 years ago

@Didiloy I saw search-movies endpoint as well, thanks. With what I found so far, I have 2 options:

1) Add a search layout to appbar and go to search endpoint when a query is entered, otherwise, go to discover endpoint 2) Have a search button/layout and open a different search UI when clicked like Google does for example in Keep Notes.

Which one you would prefer?

A quick note: TMDB includes TV movies only for these two endpoints. TV series have their separate endpoint

Didiloy commented 2 years ago

@yasinkacmaz I think the first one would be great although I like both ideas. For the TV series maybe you can do a different search UI ? If, of course, you want to allow the search of TV series.

yasinkacmaz commented 2 years ago

I am more leaning towards the first approach, it may require some adjustments though. For example, filters should not be applicable to the search. It will contain only movies now. I am planning to add TV series in the future.

yasinkacmaz commented 2 years ago

Hey @Pauler221 @Didiloy, I've created a pull request for the search feature. Here you can see the details: https://github.com/yasinkacmaz/jetflix/pull/196

Didiloy commented 2 years ago

That's really great thank you !