search

yasinkuyu / binance-trader

💰 Cryptocurrency Trading Bot for Binance (Experimental)
2.49k stars 825 forks source link

More than 1 order is taken and doesnt sell #166

Open jamesolearymsl opened 6 years ago

jamesolearymsl commented 6 years ago

Hi, I am trying out your code (thank you very much) and i encountered that an order would be placed more than once and keeps trying to fill at an unlimited amount. Also didnt seem to sell but im still testing on that one. Screen shot attached.

image

I used the command: python trader.py --symbol BCPTBTC --mode range --quantity 25 --buyprice 0.000081600 --sellprice 0.00008300

elysium-12 commented 6 years ago

I'm experiencing the same behavior, it just places orders and never sells:

python trader.py --symbol BTSBNB
@yasinkuyu, 2018
Auto Trading for Binance.com. --symbol: BTSBNB

...

Started... --quantity: 35.03000000

1.3% profit scanning for BTSBNB

Between Ask and Bid 1.3% profit hunting
buyp : BuyPrice  (Bid+ --increasing 0.00001000)
sellp: SellPrice (Bid- --decreasing 0.00001000)
...

price:0.03186000 buyp:0.03140000 sellp:0.03179807-bid:0.03139000 ask:0.03181000 spread:1.34
price:0.03186000 buyp:0.03140000 sellp:0.03179807-bid:0.03139000 ask:0.03181000 spread:1.34
Buy order created id:2412790, q:35.03000000, p:0.03140000
Buy order created id:2412792, q:35.03000000, p:0.03140000
Profit loss, called order, 2412790
Buy order fail (Not filled) Cancel order...
price:0.03186000 buyp:0.03142000 sellp:0.03181833-bid:0.03141000 ask:0.03181000 spread:1.27
Profit loss, called order, 2412792
Buy order fail (Not filled) Cancel order...
price:0.03186000 buyp:0.03142000 sellp:0.03181833-bid:0.03141000 ask:0.03181000 spread:1.27
m: UNKNOWN_ORDER
m: UNKNOWN_ORDER
price:0.03186000 buyp:0.03142000 sellp:0.03181833-bid:0.03141000 ask:0.03181000 spread:1.27
m: UNKNOWN_ORDER

I can clearly see it should have sold to achieve the target profit.

jamesolearymsl commented 6 years ago

tested out again tonight and i found my buy went in (emptied my BTC) and then created the sell orders. So in theory it worked but needs to have a limit of 1 buy etc.

Minimalist77 commented 6 years ago

Somehow the script lose control:

m: Account has insufficient balance for requested action. Buy order filled... Try sell... Buy order filled... Try sell... Buy order filled... Try sell... m: Account has insufficient balance for requested action. m: Account has insufficient balance for requested action. m: Account has insufficient balance for requested action. m: Account has insufficient balance for requested action. Buy order filled... Try sell... Buy order filled... Try sell... m: Account has insufficient balance for requested action. Buy order filled... Try sell... Buy order filled... Try sell... Buy order filled... Try sell... m: Account has insufficient balance for requested action. m: Account has insufficient balance for requested action. m: Account has insufficient balance for requested action. Buy order filled... Try sell... m: Account has insufficient balance for requested action. Buy order filled... Try sell... m: Account has insufficient balance for requested action. m: Account has insufficient balance for requested action. Buy order filled... Try sell... Buy order filled... Try sell... Buy order filled... Try sell... m: Account has insufficient balance for requested action. m: Account has insufficient balance for requested action. Buy order filled... Try sell...

He made a total of 2 Orders. He sold one and has still 1 Order in Possession. i think he forgot that sold and running now in this endless spiral.

Exeluzz commented 6 years ago

hello

i don't know why but the bot work correctly for me then suddenly he stop working great and do the same of you, enter in a loop and never go out .... Just try to sell a order but the order are selled long time ago but whyyy ??? ther bot correctly work before

EDIT : I know why and i'am stupid ...... i have 2 version of bot, the branch master and weSpeakCrypto and just only weSpeakCrypto work great !! :)

Michael5466 commented 6 years ago

where can i find the weSpeakCrypto version ?

Arghh commented 6 years ago

he has deleted hes version, it seems. you can PM him https://github.com/WeSpeakCrypto?tab=overview&from=2018-02-01&to=2018-02-28

Michael5466 commented 6 years ago

Can you forward it to me via email?

Argo Liivanurm notifications@github.com schrieb am Sa., 21. Apr. 2018, 12:31:

where can i find the weSpeakCrypto version ?

he has deleted hes version, it seems. you can PM him https://github.com/WeSpeakCrypto?tab=overview&from=2018-02-01&to=2018-02-28

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/yasinkuyu/binance-trader/issues/166#issuecomment-383283933, or mute the thread https://github.com/notifications/unsubscribe-auth/AksNW6e_6hcYvYB6nbnBpqTYZWts5QR3ks5tqwpngaJpZM4RtPth .