yasinkuyu / binance-trader

💰 Cryptocurrency Trading Bot for Binance (Experimental)
2.51k stars 826 forks source link

Signature for this request is not valid #196

Closed vitorcamachoo closed 6 years ago

vitorcamachoo commented 6 years ago

Im getting this error when spread matches with the profit margin that I define.

price:0.22787000 buyp:0.22779000 sellp:0.22789389-bid:0.22778000 ask:0.22799000 spread:0.09
m: Signature for this request is not valid.
price:0.22787000 buyp:0.22779000 sellp:0.22789389-bid:0.22778000 ask:0.22799000 spread:0.09
m: Signature for this request is not valid.
price:0.22787000 buyp:0.22779000 sellp:0.22789389-bid:0.22778000 ask:0.22799000 spread:0.09
m: Signature for this request is not valid.
price:0.22799000 buyp:0.22779000 sellp:0.22789389-bid:0.22778000 ask:0.22799000 spread:0.09
m: Signature for this request is not valid.
price:0.22799000 buyp:0.22779000 sellp:0.22789389-bid:0.22778000 ask:0.22799000 spread:0.09
m: Signature for this request is not valid.
price:0.22799000 buyp:0.22779000 sellp:0.22789389-bid:0.22778000 ask:0.22799000 spread:0.09
m: Signature for this request is not valid.
price:0.22799000 buyp:0.22779000 sellp:0.22789389-bid:0.22778000 ask:0.22799000 spread:0.09
m: Signature for this request is not valid.
price:0.22799000 buyp:0.22779000 sellp:0.22789389-bid:0.22778000 ask:0.22799000 spread:0.09
m: Signature for this request is not valid.
price:0.22799000 buyp:0.22779000 sellp:0.22789389-bid:0.22778000 ask:0.22799000 spread:0.09
m: Signature for this request is not valid.
laaksomavrick commented 6 years ago

Seeing this as well. My api key and secret is correct.

toski112 commented 6 years ago

The same

laaksomavrick commented 6 years ago

Reverting https://github.com/yasinkuyu/binance-trader/commit/c8f7977fb7783d0c3de413897a5d60cdb6b217a1 seems to have fixed it for me.

toski112 commented 6 years ago

Not working for me..

bnuccio commented 6 years ago

You will need to revert app/BinanceAPI.py to a older version

https://github.com/yasinkuyu/binance-trader/commits/master/app/BinanceAPI.py

Use the one from Jan 22nd. The changes that were made 4 days ago to this file is what is causing this.

toski112 commented 6 years ago

I didnt see Jan 22nd, reverse only BinanceAPI.py or project ?

ykartal commented 6 years ago

Could you please check the last committed BinanceAPI.py which uses API v3. See: https://github.com/yasinkuyu/binance-trader/pull/204

RedcoatAsher commented 6 years ago

@ykartal I am running most recent version of master and am still getting the error for Signature for this request is not valid image python trader.py --symbol IOTABNB --quantity 37 --profit 0.3

Also, should the _V3 url have the trailing slash. I only ask as the other two do not. image

ykartal commented 6 years ago

@RedcoatAsher Get the latest version to get fixed version, To fix it, I added V3 url to cancel method.

RedcoatAsher commented 6 years ago

@ykartal: now I am getting the UNKNOWN_ORDER issue I reported in #199

image

ykartal commented 6 years ago

@yasinkuyu this issue can be closed

yasinkuyu commented 6 years ago

Thanks