yasinkuyu / binance-trader

💰 Cryptocurrency Trading Bot for Binance (Experimental)
2.53k stars 830 forks source link

m: Signature for this request is not valid. #205

Open shayanabbas opened 6 years ago

shayanabbas commented 6 years ago

Hi guys,

i am getting this error,

screen shot 2018-02-20 at 22 18 32

I am using latest version that was updated yesterday

I run with the following command

python trader.py --symbol ADAETH --profit 0.3 --stop_loss 0

I saw it opened the trade but it was not filled, i am not sure what is wrong, I had 0.012 ETH in my binance for checking this, hopefully if it worked i'll be able to make a web monitoring system with ability to check trades and to run multiple sessions.

screen shot 2018-02-20 at 22 19 38
RedcoatAsher commented 6 years ago

+1 Also experiencing this :/

Exeluzz commented 6 years ago

it's normal when the bot try to buy it perform a order but sometimes the order are not ok so you need to wait that order are selled by other people when the order is Ok the bot can try to sell. if you have closed the bot, cancel the order and run the bot. except this time stay running and you will see what happen(the order pass and the bot can try to sell) when arrived, you have another message on the bot. it can be wait 1hours.

sry for my bad english

shayanabbas commented 6 years ago

ohh okay, well i tried closing it and canceling the order, and i ran again this time it bought ADA/ETH on 0.00040101 rate, but now price is low 0.00039800 now its showing me this

screen shot 2018-02-20 at 22 44 32

I guess this means that once the price reach above this value and get 0.3% profit it will sell it, but i have to keep it running right?

RedcoatAsher commented 6 years ago

@darubillah: that is issue #202

shayanabbas commented 6 years ago

oh okay i hope it get resolved soon, mean while i'll work on web version

Exeluzz commented 6 years ago

if it still nok you can try to put "--amout X" min_notional directly depend on that :)

This resolved for me (also try to get the WeSpeakCrypto Version of Bot)

AlgoBen commented 6 years ago

I solved the issue by passing the Params as a List instead of a Dict. As a List, you can fix the 'Signature' as the last element.

If you don't believe me, do this simple test. As a Dict, print your Params before you request.get(). If 'Signature' is the last element, Binance should accept. If 'Signature' is anything but the last element, you should get a -1022.