yasinkuyu / binance-trader

💰 Cryptocurrency Trading Bot for Binance (Experimental)
2.49k stars 824 forks source link

Buy filled but no sell #218

Open msmmi opened 6 years ago

msmmi commented 6 years ago

image

Buy order filled it buys good but during sale it places sale order and showing this window. I see sale order is successful on my binance account but bot is showing this error I put stop loss to zero. It is not restarting when sale order is successfu. Any help ?

RedcoatAsher commented 6 years ago

@msmmi... dude! It says the error

Account has insufficient balance for requested action

...means you ain't got the money :/ .

Buy order filled...

is a little misleading; it just means that a buy order has been entered, it may and seems in your case, to have not executed.

It puts in the buy and sell almost instantly, so if your buy has not gone through, and you are waiting for it to in order to have funds; this is not going to work.

You cannot be reliant on the buy going through to give you the funds for the sell, and visa-versa. You must start off with portion of each of the coins in the trading pair. I use a 50-50 split. That way over time one, the coin i want to accumulate, will grow more than the other.

arifaydogmus commented 6 years ago

@yasinkuyu bazi coinlerin fiyat artırımları 10 satoshi ve profit hesaplamasında çıkan sonucun 10 satoshilik birimlere yuvarlanması gerekiyor haliyle. Mevcut kodunda bu kontrol olmadığı için Price Filter hatası alıyor ve sonrasında yetersiz bakiye ve satış yapılamadan bekleyen alınmış coin kalıyor kullanıcıda.

Coin'in tickerSize'ına göre profit hesaplamayı round ile düzeltmek sorununu çözer. ;-)

Kolay gelsin

dorlan commented 6 years ago

If the fee deduction is not the BNB used, the number of purchases will be deducted at the time of sale. For example, my IOST balance is 0 at the beginning, and after buying 1000, my account IOST is actually 999, but if it is to sell 1000, it is sure that the -2010 balance is insufficient.