search

yasinkuyu / binance-trader

💰 Cryptocurrency Trading Bot for Binance (Experimental)
2.49k stars 824 forks source link

selling after sell order filled #239

Open mattfacer opened 6 years ago

mattfacer commented 6 years ago

The app seems to continuously try to sell even once the sell order has been completed. For example,

quantity=50 pairing=XRPBTC profit=0.3

buy 50 at 0.3 profit 2 buy orders created - both filled total = 100 coins

app creates two sell orders for 50 coins each both filled.

Now I have ZERO balance. That's fine. Yet the app just keeps showing "buy order filled... try sell" and then "account has insufficient balance for requested action". Nothing else happens. No more buy orders are created. It's stuck in a sell loop.

This earlier sold ALL of my 5000 TRX (Tron) coins! I was testing it with a quantity of 200 at a time, only to find within a few minutes it had rattled through and created LOADS of sell orders. Lesson learned there!!

screen shot 2018-04-25 at 21 41 40
LoayGhreep commented 5 years ago

Did You Solve It @mattfacer

BCvsv commented 3 years ago

I think I found it, in line 2016 sell_status should be replaced by sell_order['status'] I think, solved the loop for me

geeks121 commented 3 years ago

I think I found it, in line 2016 sell_status should be replaced by sell_order['status'] I think, solved the loop for me

you may pull request and commit it to dev