search

yasinkuyu / binance-trader

💰 Cryptocurrency Trading Bot for Binance (Experimental)
2.52k stars 828 forks source link

Stuck at saying "sell try again" instead of Selling #47

Closed shubidk closed 6 years ago

shubidk commented 6 years ago

Hey,

First of all wanna say that it is an amazing bot that has been build, and would like to say a huge thanks to Yasinkuyu.

The bot works fine with buying but has a problem when selling, and instead says "... sell try again...", anyone else have this problem? and know how to fix it?

Thank you so much on beforehand :)

borocode commented 6 years ago

just got the bot set up (mainly python set up lol) and having this error too.

gcanteen commented 6 years ago

I had this same issue when I tried about 12 hours ago, as well

yasinkuyu commented 6 years ago

I'll fix bugs next weekend.

bjeliazkov commented 6 years ago

had this issue as well. think i see the problem. looks like calc method is failing because lastBid is coming in as string rather than float. that seems to clear out the error

systemonkey commented 6 years ago

@bjeliazkov can you let us know what needs to change to get rid of the error?

bjeliazkov commented 6 years ago

open trader.py in an editor and modify calc to make lastBid a float eg.

original " def calc(lastBid): return lastBid + (lastBid * PROFIT / 100) "

modified " def calc(lastBid): lastBid = float(lastBid) return lastBid + (lastBid * PROFIT / 100) "

systemonkey commented 6 years ago

@bjeliazkov thanks for that. Unfortunately still running into issues. Error: Illegal characters found in parameter 'orderId'; legal range is '^[0-9]{1,20}$'. ... sell try again... I'll just wait for @yasinkuyu update. Much appreciate it.

yasinkuyu commented 6 years ago

@systemonkey https://github.com/yasinkuyu/binance-trader/issues/47#event-1405420092

linhndd commented 6 years ago

Thank you

yasinkuyu commented 6 years ago

https://github.com/yasinkuyu/binance-trader/commit/56d1d2b1a8ea2b9a32f924a67f04c5c1f1bc2499