yasirkula / UnityIngameDebugConsole

A uGUI based console to see debug messages and execute commands during gameplay in Unity
MIT License
2.11k stars 221 forks source link

Add New InputSystem Compatibility #32

Closed vmichalak closed 3 years ago

vmichalak commented 3 years ago

I've add a support for the new input system without breaking the old one.

vmichalak commented 3 years ago

This MR solve issue #31

yasirkula commented 3 years ago

I have a couple of trivial changes to your latest commit in my mind but the most important thing right now is this:

We must test if this breaks compatibility with Unity versions 2017.3 to 2018.2 where Assembly Definition Files exist but apparently, new Input System doesn't.

I'll give it a shot soon.

yasirkula commented 3 years ago

I'm sorry for the delay. This PR is still in my to-do list but I've been busy with work. Just wanted to let you know.

vmichalak commented 3 years ago

No Problem @yasirkula, I only did this PR because I corrected the lib for me. Take the time you need.

yasirkula commented 3 years ago

So today I've made some research about the new Input System:

As you can see, there are a lot of manual changes needed just to be able to access new Input System from scripts. Manual changes also means that asset mustn't be installed through Package Manager because package source codes aren't included in version control system and thus, the changes won't persist on version control or when Library folder is deleted (e.g. cloning the project).

All these negative points strongly discouraged me from adding support for new Input System. I may revisit this issue later.

HyVong007 commented 3 years ago

My temporary solution is using both old input system (UnityEngine.Input) and new Input System in my project. But i wish that you will use InputSystem very soon.

yasirkula commented 3 years ago

Issue addressed in https://github.com/yasirkula/UnityIngameDebugConsole/commit/6123ac72027a0cc2355465562ce598b96079351c