search

yasirkula / UnityNativeShare

A Unity plugin to natively share files (images, videos, documents, etc.) and/or plain text on Android & iOS
MIT License
891 stars 131 forks source link

Receiver Email Added #80

Closed Keshavjps28 closed 4 years ago

Keshavjps28 commented 4 years ago

Hello Süleyman I have added a functionality to allow the user to set recipient E-mail in case of E-mail share as discussed in this issue(https://github.com/yasirkula/UnityNativeShare/issues/79). This is my first attempt at open source contribution hence would request you to guide me with the process.

yasirkula commented 4 years ago

Did you test the code yourself and verify that it works?

Keshavjps28 commented 4 years ago

Yes

yasirkula commented 4 years ago

Sorry for the doubt but I'm sure that the following line will change the text instead of setting the recipient:

if( recipients.length() > 0 )
    intent.putExtra( Intent.EXTRA_TEXT, recipients );

And there are numerous compilation errors in NativeShare.cs...

Keshavjps28 commented 4 years ago

I got it, Somehow EXTRA_TEXT is replaced by EXTRA_EMAIL, Due to that Error is occurring.

yasirkula commented 4 years ago

Here's your NativeShare.cs file in full. This is probably not in sync with your own NativeShare file since there are compiler errors (undefined recipients variable, multiple SetTitle function declarations and etc.).

I am not planning to add recipients functionality at the moment but thanks for creating this pull request 🙂