yasirkula / UnitySimpleFileBrowser

A uGUI based runtime file browser for Unity 3D (draggable and resizable)
MIT License
819 stars 111 forks source link

Fix error adding directory name in selecting directory mode #4

Closed Arcanils closed 6 years ago

yasirkula commented 6 years ago

I believe that the browser should pick the currently highlighted folder in folder select mode rather than always selecting the folder we are currently in (Windows file picker also seems to select the highlighted folder).

Despite that, I agree that it should be easier to select the folder that we are currently in. Adding these lines to the setter function of CurrentPath property will clear the filenameInputField when the path changes, which makes it possible to select the current folder:

if( m_folderSelectMode )
    filenameInputField.text = string.Empty;
Arcanils commented 6 years ago

Thx for the reply. Indeed if you view this way, it makes sense.

Anyway, this is a nice work and I wanted to help you fix this behaviour.

Have a nice day.

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Garanti sans virus. www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

2017-10-23 23:28 GMT+02:00 Süleyman Yasir KULA notifications@github.com:

I believe that the browser should pick the currently highlighted folder in folder select mode rather than always selecting the folder we are currently in (Windows file picker also seems to select the highlighted folder).

Despite that, I agree that it should be easier to select the folder that we are currently in. Adding these lines to the setter function of CurrentPath property will clear the filenameInputField when the path changes, which makes it possible to select the current folder:

if( m_folderSelectMode ) filenameInputField.text = string.Empty;

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/yasirkula/UnitySimpleFileBrowser/pull/4#issuecomment-338802289, or mute the thread https://github.com/notifications/unsubscribe-auth/AFIB2J62D2ddyy9Pp91D4CTcfnMM6XHbks5svQUNgaJpZM4QDAu2 .