search

yask123 / Instant-Music-Downloader

🎷 Downloads Music From The Web
http://iyask.me/Instant-Music-Downloader/
1.41k stars 161 forks source link

Remove tags from lyrics #109

Closed ritiek closed 8 years ago

ritiek commented 8 years ago

Prevents tags like <br>, <p>, </p> .. etc. from being present in the output lyrics. (the old code did not seem to work somehow)

mention-bot commented 8 years ago

@Ritiek, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yask123, @sulami and @atuljangra to be potential reviewers.

ritiek commented 8 years ago

I've changed the variable names.. Does it look okay now?

yask123 commented 8 years ago

@Ritiek Looks much better now. Just one more thing, can you squash all commits into one before I merge this?

ritiek commented 8 years ago

@yask123 I'm not sure but isn't it the author of the repo who chooses this at the time of merge?

yask123 commented 8 years ago

Yea @Ritiek you are right. Github added this feature lately, I had forgotten about this.