search

yask123 / Instant-Music-Downloader

🎷 Downloads Music From The Web
http://iyask.me/Instant-Music-Downloader/
1.41k stars 161 forks source link

feature: Metadata #38

Open Otoris opened 8 years ago

Otoris commented 8 years ago

What if this could grab the relevant file metadata + file title and apply it after it's been downloaded from YouTube automagically? Would definitely help keep an iTunes library clean.

picklepicklepick commented 8 years ago

Don't YT files have ID3 tags in them anyway?

yask123 commented 8 years ago

It is possible to implement this. I recently wrote which grabs just album art for all your downloaded songs, you can try it : http://iyask.me/fixalbumart/ I'll work on it if I get some time in weekend.

gamegoofs2 commented 8 years ago

I tried implementing youtube-dl's "--metadata-from-title" and "--add-metadata" but things weren't turning out well. I tried downloading Only Love by Mumford and Sons and it thought the title was "Only Love - Mumford and" and the artist was "Sons".

I'd be willing to add this feature if anyone has any ideas of pulling the metadata from the youtube download.

yask123 commented 8 years ago

Added this feature in commit https://github.com/yask123/Instant-Music-Downloader/commit/71145bc3e0cf2eba5e7b2aa3082cd38d13ae66ad Update sudo pip install instantmusic --upgrade to try.

yask123 commented 8 years ago

Not closing this issue since Its not 100% complete. Currently it assumes the song tittle in youtube is written as Artist name - Song name which is true in most of the cases.

ewtdsar

Thus it currently doesn't write album name.

I plan to fix this in future. See: https://github.com/yask123/Instant-Music-Downloader/blob/master/README.md#mp3-tags

Otoris commented 8 years ago

Something like gracenote or ACRCloud could be used to grab metadata. Only issue is it requires uploading at least a part of the song after it is downloaded by youtube-dl.

ssundarraj commented 8 years ago

Musicbrainz requires you to fingerprint and send the song. This could be used instead of uploading the entire song.

yask123 commented 8 years ago

Yep , Musicbrainz cromaprint is awesome, trying it.

[Update] Unfortunately , for the given file : it couldn't return any result:

URL with fingerprint: `http://api.acoustid.org/v2/lookup?client=ULjKruIg&meta=recordings+releasegroups+compress&duration=641&fingerprint=AQADtMpCLmawcsUTHX_wH8meBGFC6rjwaAueOcaPUnqM5pIRR01yqA_OHK5I6IuO5kbOKEdaFdV1Q_6Rv8FNJfiCMtfR7HFwZshH6NjiHPpz4YS5PAlyC1UeNDnOIC-03ERftEd5sB20ZApzhMswPWhCyzizIM94JDduo9mYokyUHP0D_6idyriSC-3yCDm2d0fZPZAuHj9GSkPeJJHRoOKHL0dzoj8uU4gfqKk-pB-X40uIHzNy5QkSOpeCyxGuScNFBmfQ3_hQrjn-IJeQPBUJ_-Bxi8ZDrFuZw86R_Ij05Ghe_EUb5UKiZAtyVDm2sSVRKdlu_Jh8-EcifUXoXHhyXB2mhYkCZxuuw83E40uDYybamGAkpalh_fCLrbvR58M3XEaTXyiVMMNP_JgSRugiVRLi9dDyDOGXqHiP_UGz5fiC6hK-HD_iI7l09Mrh8_hyfMoEj1EcnDpyJ8etQ5QWD3-GdM-EUkp0VEfz4jYuiUO-CLUOH0-24zq8x5ik4zl-OIny4GKKKc_wKiG09Milj-hxH3fQf7hO9A_sHz-eo8_xPOhzNFkUBf2L5sEl4T5O48GYzUMfpkOahTr0I314TDWDH6W-48kSoieaGVXxI6lP5Mlc9FFy-BcuBt7T4Md9XM9hXRbC8oOOipKC9IEv1MN5XBpXnPgxxcUjKYidw3oaoY-Cb7qgC_3hiimOUj7OB3mOHHcySdh1oy_hjyh79B3SHh55tMuOv0N_NA-PH0FTXBREUsGFH8ZzHCmOH8eDw37xA_7RH-EvJEfDbsNxkfjxw41c4HrxbA-eKV_xG03FcOhH5Dp-6MpRsSGmqIli4r7QXAidSDlmKWWCK-ilHJ4URfjRBj9-5JoV4Y4D3aimSEbTT8WTPnim4cyR58hRSswEfwjp47jwi3hzIR9uVItCiM6PcCE-Hvkd6GjKIqQi4tvhUXpxGm941Agz5cSzDP0Da0dHRSkef7hxhvh0PEfDR-h55Mc5UTiP50rQMwjjybhy4VsFLaEaonOO6kSkHFeEXV_wFH2yfHC14xuK_3gu5BEPPRbyo8mSBl0zarhIKsEfPMd9JHOOXGIKr0N46D5y7fhV1FSK7zNO5FkaiNrxJbtx5oR2hPvROEuEUouOZhmOnIEWGVc0uCcUlcd7BbkUNE0yTFoetCfCvIc-XcgfOE6GH1-QH3KPsNkaNHqiLMCPUx8aJxLCTYcmhKnCEc_xoJTCE56EfsaJf0N-6IfrMMiP7-godnCkB48qhLlGXNB1GTljlB2F5sapI99X_OgbF41bFu-z4Ays9tAlPHlS5FIP7xqu4WaDh8Z_9EQYjunwyBaeH0fOVPiFUkrEBRbToj5uHg_y4zm05GGEPpyI-zj04xd85O-Cf8gjxXAopgl-aHmGUFTm4bnwC8151D2e48iPKz40qwzCfDieHU2SZXJwThV8HSE_C8Jz5GmKZj1KCmcY5MeF6qFCeOvRF28OLW-P_g2eDyUlhKF7vDouLSKuC1eK5keb49nxHcdznMlRThGRVod2AtFP4dGD70FXpsJ1JMyoI6R4PNpxV9hUC3eWxnj6oeRyJMuVIz-u471ydAkXpmgm87iNXYly5JcO8UM8vUN3FqbCILxSDdfh3tCFcM_g50afFbkO7WXQR0POD-XR_PifovyFhmNwTegiHc2HeNShEWH24LGLN7rQTUez8njEBznU6eiP5rga4sebHNYc_A208kFz5MuR67iOWoW7o9-R9MUx9UcTa8Zd3DGaY7qUBokVRUcYF49KonkiCz9xKWwFuznyaCn0IyyFf_iMXsrxEbVUobmRUw40_XBPFo-kGT_Y45GmQDrSccnwCz8ansOZ4xWaCv2KxKkQfmhmZXg-_EEzMmPxDPmO_tAV9Dn8oBbxHeGzo5le3EGTH-VzPDqeXMUE20cfF9eHHw-PZjp640czXQi3iF2g9wgT9UN54cdbJUepw2myDJdQHj_it0ieCz2Dx8IjXGEO38HHiRp-_Dk-B33wHbWGhOuQn8U1mEqEWtQU_B6aHq02XIqOJn7QF-_RKTzCRLtQqxWaR0FZwhWL5MmD6zh647SOWhnspsP5BLng_sLFBnkON0W_hHiO_sI_PD_qhHjwfWisIRTFFFr7COmzoF8Wog0Pf8cXiniId0KJH_GhH-GZ4JlhbvgzCU_2ID1F_Ed-CumYXEGlRMT3oc8Efyd0abClHBWPSxyqCy6ebPAv3BH6JWiXC87xKHWIJhRxXDuUfTp-7DlKC08TPJqOtONxVcWPS4QnMfCy7EVfoHk4I9SPxA_6ffCe49RgR8rRBj-qI8yYI_kkPBdK7YJ_VO-MNzm-6MJDH96Jh7gs5MQ_qNRgNRmF-8KUMwgdTZilD1-CPtHhTzmuFG2O40e-J3icTdD_IRQTiTKaaSyeB1c6nDnxIleOWvCXoleF3M9xHb8WPA9qTjgeIl5EQ1QWIjyRiz7-oGbROCH0RAq845mD-6gTkmgmHw9xOkPTo04Spfjx4wy-D094NI8QnsdPfMT34MuVoJdyhPnxhgy-QtMiKWjkVajEI1Le4NGx6wvxoJcSeIzyCSf640d-4YfuGLnRZEmpBl2Z4mLmBH-GB3eRzEEuSfCaFeEPHY-O_NJwKkd7OH7xLEa-4wue5eh9dA_sSEO6ZEmCSvyR46YDLdqIchq05kTzY3-Qf9iYaNHwDz_SF_ryIJdECmKJc4QYoyhTzAAgCVGKCCCIMoIwhARgABkgCCOSAEQAZhwpIgxDSBBkCBESIAGUskARJbBAQgjgGDZEAAGwMA4YaZgClmlACCBQQQIMAQpZoCgiFBAHHJgAGGAEMsYwAgUQRgplnCBYMGuAMUAYooAygAgGhNICKWO0IQ444qBhCgmiCBAIIgIkIAQAKigTRBllhKFIAQACQAYAKAxQQoiFBADCCEcwAEIAAAFSEjGkDCECCAAUREYg5I0CRBEFFCBECCCoAFZAZ8QjSntCDBSAEGAICCQgCAgRgChChFBIIGCI0IIp6g1yBBEADCWIWCQIYgog4LQhSADCDSNOCMaEUQZQhghCjACAgSFKCEUMUYoI4AWAxCijBAHQKECEc0YRgQUwRAEAmLKEMICBVGIRR4RQigFAAEIQGaWAAAAYpgwoSBmJjABGAcQYIIIoQIwCUAEgiMIKKQGYUIggKRARTlEAgDEQKGSAQOAoRBQQQBpBkSJICcaUMtAYBrhRAABiFCLSCXKAFBYAQJggQhgkQFBAUERIFUgIIRQyjjAADSIAECGIYggxQAAAQghgBCKAGaAcAsIYAwgBgAIBBACMAGEAMUBAiwhChjFAgDGKOIMMU4IoBRgCSBADKCAASMGMEAAoYgQA0EBloFAWMAGMMkohJoQxQhCEFABAGCCMMYoYgQyySgAFqBKEAKYMUEwJBBERkhmHgBVCCCaAEARBAQkyjCihhCEIUsaAIRIgpIxwRBhgDBBgKAGEgIAwIMRVBDAiFAAACUAARAIoAABzRhAqiBCOCAWcIY4yAhgoFDBgBADACQqYUEIiRYhBwgCBiGDEGwQMMFo4QIiVCSFhBBBAQgKMIMIIQJBRQBLUiBECAs0EUYwphgxjSBhACRACIEGEIIgQZgASAnhBEDDGI2IcMYAIZ4QC3CgEEDGOAUUYUAIK4YETxBhAEAMSEEAA``

Response:

{"status": "ok", "results": []}
dufferzafar commented 8 years ago

AcoustID lookups only work for what's already in the database and I don't think anyone has ever submitted IDs of youtube videos before, so that method probably won't work!

yask123 commented 8 years ago

Damn :disappointed:

Only alternative I can think of is to do google search with song tittle and scrape meta data from websites ?

ssundarraj commented 8 years ago

@dufferzafar I think it might work for YouTube videos. As far as I know, it matches the fingerprint of the song. It doesn't really matter where you download it from as long as that song is in the database.

yask123 commented 8 years ago

@ssundarraj It didn't work, I tried multiple times with different songs downloaded from youtube.

gamegoofs2 commented 8 years ago

I found something the other day. It was called EchoNest. It might work. On Oct 14, 2015 8:49 AM, "Yask Srivastava" notifications@github.com wrote:

@ssundarraj https://github.com/ssundarraj It didn't work, I tried multiple times with different songs downloaded from youtube.

— Reply to this email directly or view it on GitHub https://github.com/yask123/Instant-Music-Downloader/issues/38#issuecomment-148040056 .

yask123 commented 8 years ago

Tried this hack to grab album name

album_name=''
        try:
            url = 'http://www.google.com/search?q='+qp(title)
            req = requests.get(url)
            response = req.content
            result=str(response)
            link_start=result.find('http://www.metrolyrics.com')
            link_end=result.find('html',link_start+1)
            link = result[link_start:link_end+4]
            lyrics_html = link
            a = requests.get(lyrics_html)
            html_doc=  a.content
            soup = BeautifulSoup(html_doc, 'html.parser')
            album_name = soup.find(id = "album-name-link").text
        except:
            print ('Album name not found')

Tested multiple times with different songs, seems to work for most of them. It would work for songs which have their lyrics in metrolyrics.com. From there I am scraping the meta data. Eg: http://www.metrolyrics.com/21-guns-lyrics-green-day.html

from 21st Century Breakdown

yask123 commented 8 years ago

Pushed it to the source: bd2d28bff904bd3d5e27ab4c9984f5cc5ea70c6a

This will embed artist name, song title, album name, album art.

Have a look here: https://github.com/yask123/Instant-Music-Downloader/blob/master/instantmusic-0.1/bin/instantmusic#L123

Since I haven't updated the package yet, run $ sublwhich instantmusic``

Replace subl with whichever code editor you use, and replace all code with: https://github.com/yask123/Instant-Music-Downloader/blob/master/instantmusic-0.1/bin/instantmusic

yask123 commented 8 years ago

Updated package. Run pip install instantmusic --upgrade to try.

kniacdz
semaj commented 8 years ago

@yask123 I notice in the above picture the song has the last character cut off.

I am experiencing this too - the actual filename is fine but whenever I open it in any media player (Plex, iTunes, cmus) it's cut off. Any idea what that could be?

yask123 commented 8 years ago

@semaj Thanks for reporting. Yes this issue exists. It's a minor bug (Indexes for slicing text are not accurate). I'll fix this bug after my exams get over (5th December).