yask123 / Instant-Music-Downloader

🎷 Downloads Music From The Web
http://iyask.me/Instant-Music-Downloader/
1.41k stars 161 forks source link

Revert "Modifying requests to work with proxy" #96

Open hut8 opened 8 years ago

hut8 commented 8 years ago

This reverts commit d16899dd46b45faaf724eded7d13dcb6e7e8beaf.

Reason:

I'm not sure why this was necessary in the first place, but this commit: https://github.com/kennethreitz/requests/commit/0ba8c44260209ff518809a6b5b307d443e8dfe67 has been included in Requests since v0.12.1 in 2012, which transparently adds the same stuff but accounts for more cases. For example, it handles NO_PROXY correctly, and there are other places that allow for http_proxy instead of HTTP_PROXY to work. So this commit actually introduces some bugs, and in general just makes the API of requests a harder to use. I found this was redundant while trying to add a parameter to requests (specifically, payload=), so it's making a refactor (plus several character encoding / Py3K fixes) more difficult.

hut8 commented 8 years ago

Whoops, please don't merge yet -- I just realized that this is also the commit which removed the requirement for urlopen which I've already removed. Couple minutes :smile:

hut8 commented 8 years ago

OK, fixed.

hut8 commented 8 years ago

Still waiting