search

yasminaly / restaurant-website

Create a wireframe/prototype for the restaurant website you planned and designed in another class.
0 stars 0 forks source link

@thomasjbradley #1

Open yasminaly opened 8 years ago

yasminaly commented 8 years ago

I have 2 issues that I cant figure out. Markbot is telling me I have a parse error and I cant figure out how to fix it. My toggle and navigation bar disappeared and I cant get them back.

thomasjbradley commented 8 years ago

The reason this issue didn't notify me is because the @thomasjbradley can't be in the title, in needs to be in the description.

For the parse error: there's a closing curly brace missing for one of the media queries, here: https://github.com/yasminaly/restaurant-website/blob/gh-pages/css/main.css#L208

For the toggle, I have a couple ideas:

  1. Make the font-size of the logo a little bigger
  2. Don't float the logo, because it doesn't need to be floating if the nav button is position: absolute

The hover error in Markbot is because the navigation isn't visible on large screens, so Markbot can't hover over the links.

If it says some files are waiting to be committed, you'll probably have to make more commits. It's going to check that all the files are committed and synced.

yasminaly commented 8 years ago

Hi Thomas, I am finally done with the website. I have attached a screenshot from markbot as well as the text file. here is the link to my code: https://github.com/yasminaly/restaurant-website

Do I need to send you anything else or is the github link enough?

Thank you so much for your patience and understanding.

Hope you have a great summer

Yasmin

On Tue, May 10, 2016 at 2:08 PM, Thomas J Bradley notifications@github.com wrote:

The reason this issue didn't notify me is because the @thomasjbradley

can't be in the title, in needs to be in the description.

For the parse error: there's a closing curly brace missing for one of the media queries, here:

https://github.com/yasminaly/restaurant-website/blob/gh-pages/css/main.css#L208

For the toggle, I have a couple ideas:

  1. Make the font-size of the logo a little bigger
  2. Don't float the logo, because it doesn't need to be floating if the nav button is position: absolute

The hover error in Markbot is because the navigation isn't visible on

large screens, so Markbot can't hover over the links.

If it says some files are waiting to be committed, you'll probably have to make more commits. It's going to check that all the files are committed and synced.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/yasminaly/restaurant-website/issues/1#issuecomment-218241877

thomasjbradley commented 8 years ago

Thanks. That's all you need to submit—I'll mark it and change your official grade.

What was the text file attachment? None of the attachments showed up in the GitHub issue.